Skip to content

Commit f1e9177

Browse files
WeltraumschafManuelNeuer
authored andcommitted
#36 Extract constant
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent c628f71 commit f1e9177

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/main/java/io/securecodebox/persistence/defectdojo/service/DefaultImportScanService.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.springframework.http.client.ClientHttpRequestFactory;
2626
import org.springframework.http.client.HttpComponentsClientHttpRequestFactory;
2727
import org.springframework.http.converter.FormHttpMessageConverter;
28+
import org.springframework.http.converter.HttpMessageConverter;
2829
import org.springframework.http.converter.ResourceHttpMessageConverter;
2930
import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;
3031
import org.springframework.util.LinkedMultiValueMap;
@@ -39,6 +40,10 @@
3940
* https://defectdojo.security.iteratec.dev/api/v2/oa3/swagger-ui/#operations-tag-import-scan
4041
*/
4142
class DefaultImportScanService implements ImportScanService {
43+
private static final List<HttpMessageConverter<?>> HTTP_MESSAGE_CONVERTERS = List.of(
44+
new FormHttpMessageConverter(),
45+
new ResourceHttpMessageConverter(),
46+
new MappingJackson2HttpMessageConverter());
4247
private final SystemPropertyFinder properties = new SystemPropertyFinder();
4348
@Getter
4449
private final String defectDojoUrl;
@@ -80,11 +85,7 @@ private ImportScanResponse createFindings(ScanFile scanFile, String endpoint, lo
8085
// 1. generic info as key=value&key=value...
8186
// 2. the raw scan result as file
8287
headers.setContentType(MediaType.MULTIPART_FORM_DATA);
83-
restTemplate.setMessageConverters(List.of(
84-
new FormHttpMessageConverter(),
85-
new ResourceHttpMessageConverter(),
86-
new MappingJackson2HttpMessageConverter())
87-
);
88+
restTemplate.setMessageConverters(HTTP_MESSAGE_CONVERTERS);
8889

8990
// FIXME: Why do we use a multi value map here? Do we need multiple values for any given key?
9091
final var body = new LinkedMultiValueMap<String, Object>();

0 commit comments

Comments
 (0)