Skip to content

Conversation

@BaptisteCecconi
Copy link
Collaborator

Since I'm willing to add new functionalities on the package, I wanted to make sure that the tests were running correctly before starting.

I realised some tests were failing because remote data changes at ESA and NASA.

Here is a PR that fixes those issues.

@BaptisteCecconi
Copy link
Collaborator Author

@seignovert: it seems we need to update the .github/workflow/actions.yml file to upgrade the version of python used for the tests.

@BaptisteCecconi
Copy link
Collaborator Author

I updated the pylint configuration and very slightly edited some files to be compliant with flake8, pylint and bandit.

@BaptisteCecconi
Copy link
Collaborator Author

I also updated the expected results in the example notebooks and the docs.

@BaptisteCecconi
Copy link
Collaborator Author

BaptisteCecconi commented Feb 28, 2025

All checks are now passing fine.

@seignovert : I let you do the merge when you prefer.

@seignovert
Copy link
Owner

Hello @BaptisteCecconi,

Everything looks good to me 👍

Thank you very much for this update.

@seignovert seignovert merged commit 66797da into seignovert:main Mar 3, 2025
5 checks passed
@BaptisteCecconi BaptisteCecconi deleted the update-remote-tests branch March 3, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants