"TWO_DIRECTIONS" feature in AngularSeparation

[BaptisteCecconi]

I implemented the TWO_DIRECTIONS feature in AngularSeparation calculation.

[BaptisteCecconi]

@seignovert, you should probably review how I implemented the direction object. See in calculation.py, and the Direction specification in the WebGeoCalc API.

[seignovert]

Crap… They should have put 2 different endpoints for this one and not reuse the existing one.

I'm taking a look into the code and push some edits if needed.

Should I bump to a new minor version after this merge or do you want to add additional things in an other MR?

[BaptisteCecconi]

If you are ok with the changes, I don't have extra features at this point.

However, I think we could do better in checking the Direction object attributes. There are many configurations with various required attributes. I didn't spend so much time on implementing those checks.

And yes, it can be a minor version bump, since the interface for the previous AngularSeparation calculation is unchanged.

[seignovert]

There is still some new endpoints that are not covered yet (PHASE_ANGLE, POINTING_DIRECTION, TANGENT_POINT and almost all GF_*). I will create a dedicated MR to raise an errors on those before releasing a new minor version.

[seignovert]

I'm putting the MR in draft status, there is few things I want to refactor first before merging ;)

[BaptisteCecconi]

Ok, no problem, I was expecting that you would have a look and update my proposal. Let me know if I can do anything to speed this up.

[BaptisteCecconi]

I checked your commits: Great! 👍
That's basically what I thought we should do, but didn't have a motivation to update the code that much.