Partially revert encoders #20
Merged
+51
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DynamicCake
reviewed
Jan 13, 2026
Contributor
DynamicCake
left a comment
DynamicCake
left a comment
There was a problem hiding this comment.
Just want some clarification on certain decisions
|
|
||
| @external(erlang, "glua_ffi", "coerce") | ||
| pub fn table(values: List(#(Value, Value))) -> Value | ||
| pub fn table(lua: Lua, values: List(#(Value, Value))) -> #(Lua, Value) { |
Contributor
There was a problem hiding this comment.
Why does this do what luerl:encode but manually?
Owner
Author
There was a problem hiding this comment.
Because of nested tables. If we try to call luerl:encode on a list that already have encoded values inside it will result in a runtime error.
src/glua_ffi.erl
Outdated
| false. | ||
|
|
||
| encode(X, St0) -> | ||
| case is_encoded(X) of |
Contributor
There was a problem hiding this comment.
I long for the day that we don't need to check is_encoded and instead rely on the type system.
Its fine if this doesn't get fixed.
Owner
Author
There was a problem hiding this comment.
I'm exploring a way of removing is_encoded, I will update this when I got it working.
selenil
force-pushed
the
fix/revert-table-and-userdata-encoder
branch
from
6ca1b27 to
5dd4aab
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.