Skip to content

feat: add support for python3.12 and 3.13 #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiwarishubham635 merged 9 commits into from
Apr 15, 2025
Merged

feat: add support for python3.12 and 3.13 #1087

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d7b1215
feat: add support for python3.12
meysam81 Aug 24, 2024
4a7d436
Merge branch 'main' into main
tiwarishubham635 Apr 11, 2025
cdf71ee
Update Makefile
meysam81 Apr 11, 2025
b969181
chore: add python3.13
tiwarishubham635 Apr 12, 2025
6dc3037
Update Makefile
tiwarishubham635 Apr 12, 2025
8077ef3
chore: add python 3.13
tiwarishubham635 Apr 12, 2025
2653f18
chore: add python 3.13
tiwarishubham635 Apr 12, 2025
9398696
chore: Update Makefile
tiwarishubham635 Apr 15, 2025
cacca87
Update Makefile
tiwarishubham635 Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
timeout-minutes: 20
strategy:
matrix:
python-version: [ '2.7', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11' ]
python-version: [ '2.7', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12' ]
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add 3.13 here as well?

env:
DOCKER_LOGIN: ${{ secrets.DOCKER_USERNAME && secrets.DOCKER_AUTH_TOKEN }}
steps:
Expand Down
6 changes: 2 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@ venv: clean
virtualenv --python=python venv

install: venv
. venv/bin/activate; pip install -r test/requirements.txt
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me why do we need to change the makefile? I think we can skip this

. venv/bin/activate; python setup.py install
. venv/bin/activate; pip install -r requirements.txt

test-install: install
. venv/bin/activate; pip install -r test/requirements.txt

test: test-install
test: install
. venv/bin/activate; coverage run -m unittest discover -s test/unit

test-integ: test
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,6 @@ def getRequires():
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
]
)
1 change: 1 addition & 0 deletions test/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ coverage
mock
itsdangerous==1.1.0
markupsafe==1.1.1
setuptools
7 changes: 6 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# and then run "tox" from this directory.

[tox]
envlist = py27, py34, py35, py36, py37
envlist = py27, py34, py35, py36, py37, py312

[testenv]
commands = coverage erase
Expand Down Expand Up @@ -39,3 +39,8 @@ basepython = python3.6
commands = {[testenv]commands}
deps = {[testenv]deps}
basepython = python3.7

[testenv:py312]
commands = {[testenv]commands}
deps = {[testenv]deps}
basepython = python3.12