Skip to content

Conversation

@eaasna
Copy link
Collaborator

@eaasna eaasna commented Jun 26, 2024

  1. Incorporate stellar3 headers instead of submodule
  2. Replace seqan2::Dna and seqan3::dna4 with seqan2::alphabet_adaptor
  3. Replace seqan2::String with std::span

@codecov
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (519f212) to head (3113d9b).

Current head 3113d9b differs from pull request most recent head 1115648

Please upload reports for the commit 1115648 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files           2        2           
  Lines          72       72           
=======================================
  Hits           68       68           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SGSSGene SGSSGene marked this pull request as ready for review July 31, 2024 17:04
@SGSSGene SGSSGene marked this pull request as draft July 31, 2024 17:04
@eaasna eaasna changed the title Suggestions from code review Remove duplicate alphabets and replace seqan2::String Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants