Skip to content

Remove customer carve-out for ordering over a whole table (no longer required) #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acco merged 1 commit into from
May 14, 2025
Merged

Remove customer carve-out for ordering over a whole table (no longer required) #1464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions lib/sequin/runtime/message_handler.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,12 +513,6 @@ defmodule Sequin.Runtime.MessageHandler do
defp get_fields(%Message{action: :update} = message), do: message.fields
defp get_fields(%Message{action: :delete} = message), do: message.old_fields

# Carve-out for specific customer that needs strict ordering *per table*.
# Replace with a grouping function when that feature ships.
defp generate_group_id(%SinkConsumer{account_id: "88a83ac5-16bd-4f38-89d2-31375e660f6f"}, %Message{} = message) do
to_string(message.table_oid)
end

defp generate_group_id(consumer, message) do
# This should be way more assertive - we should error if we don't find the source table
# We have a lot of tests that do not line up consumer source_tables with the message table oid
Expand Down
Loading