test: Add tests for apply and check / 💎 Add minitest-reporters
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshimaru
force-pushed
the
better-test-experience
branch
from
2e593d3 to
2605981
Compare
toshimaru
changed the title
apply and check / 💎 Add minitest-reporters
There was a problem hiding this comment.
Pull Request Overview
This PR adds tests for the Serverkit::Resources::MiseInstall resource methods (apply and check) and updates the test suite to use minitest-reporters for improved test output formatting.
- Added tests for the apply and check methods in test/serverkit/resources/test_mise_install.rb
- Updated test/test_helper.rb to configure minitest-reporters
- Updated Gemfile to include new gem dependencies without fixed version constraints
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_helper.rb | Configures minitest-reporters for enhanced test output |
| test/serverkit/resources/test_mise_install.rb | Adds new tests for the MiseInstall resource methods |
| Gemfile | Updates gem dependencies, removing fixed version constraints |
| gem "rake", "~> 13.0" | ||
| gem "minitest", "~> 5.16" | ||
| gem "standard", "~> 1.3" | ||
| gem "minitest" |
There was a problem hiding this comment.
[nitpick] Removing version constraints for gems may lead to unexpected dependency upgrades; consider specifying version ranges to ensure stability in your testing environment.
Suggested change
| gem "minitest" | |
| gem "minitest", "~> 5.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.