Skip to content

Conversation

@toshimaru
Copy link
Member

@toshimaru toshimaru commented May 6, 2025

grep latest version using mise latest name.

mise install yarn:

  - type: mise_install
    name: yarn
2025-05-06 17:38:41 (9.14 MB/s) - 'yarn' saved [3010104]
mise yarn@4.9.1    ✓ installed
Finished with 0 on localhost
Running mise ls yarn | grep "$(mise latest yarn)" on localhost
yarn  4.9.1
Finished with 0 on localhost
[DONE] mise_install yarn on localhost

grep latest version using `mise latest name`.
@toshimaru toshimaru force-pushed the fix-latest-version-check-mise-install branch from 318323d to fbc91f0 Compare May 6, 2025 08:39
@toshimaru toshimaru marked this pull request as ready for review May 6, 2025 08:56
Copilot AI review requested due to automatic review settings May 6, 2025 08:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the latest version check command by updating the grep command to properly use the latest version when no specific version is provided.

  • Updates the check method to conditionally use the version if set
  • Replaces the original version_or_latest method with direct string interpolation in the command
Comments suppressed due to low confidence (1)

lib/serverkit/resources/mise_install.rb:21

  • [nitpick] Consider using a consistent quoting style for the grep pattern across both branches of the conditional to enhance readability and reduce potential confusion.
          "$(mise latest #{name})"

@toshimaru toshimaru merged commit f8f9883 into main May 6, 2025
12 checks passed
@toshimaru toshimaru deleted the fix-latest-version-check-mise-install branch May 6, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants