feat(connection): add explicit connection parameter support #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Connect() method accepting connection string as parameter - Implement connect_database MCP tool with parameter validation - Support both full URL and individual connection parameters - Add buildConnectionString() helper with defaults (port=5432, sslmode=prefer) - Refactor tryConnect() to delegate to Connect() method - Remove auto-connect from New() constructor for explicit control - Update error messages to guide users to connect_database tool - Maintain backward compatibility with environment variables as fallback - Update all integration tests to use explicit Connect() calls - Add comprehensive unit tests for connection builder and Connect() method Implements #36
8 tasks
sgaunet
deleted the
36-pass-connection-string-as-parameter-instead-of-reading-from-environment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #36