Skip to content

refactor: replace magic string "public" with DefaultSchema constant #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgaunet merged 1 commit into from
Dec 7, 2025
Merged

refactor: replace magic string "public" with DefaultSchema constant #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ func setupListTablesTool(s *server.MCPServer, appInstance *app.App, debugLogger
listTablesTool := mcp.NewTool("list_tables",
mcp.WithDescription("List tables in a specific schema"),
mcp.WithString("schema",
mcp.Description("Schema name to list tables from (default: public)"),
mcp.Description(fmt.Sprintf("Schema name to list tables from (default: %s)", app.DefaultSchema)),
),
mcp.WithBoolean("include_size",
mcp.Description("Include table size and row count information (default: false)"),
Expand Down Expand Up @@ -326,7 +326,7 @@ func handleTableSchemaToolRequest(
}

// Extract schema (optional)
schema := "public"
schema := app.DefaultSchema
if schemaArg, ok := args["schema"].(string); ok && schemaArg != "" {
schema = schemaArg
}
Expand Down Expand Up @@ -364,7 +364,7 @@ func setupTableTool(s *server.MCPServer, appInstance *app.App, debugLogger *slog
mcp.Description(config.TableDesc),
),
mcp.WithString("schema",
mcp.Description("Schema name (default: public)"),
mcp.Description(fmt.Sprintf("Schema name (default: %s)", app.DefaultSchema)),
),
)

Expand Down Expand Up @@ -539,7 +539,7 @@ func setupGetTableStatsTool(s *server.MCPServer, appInstance *app.App, debugLogg
mcp.Description("Table name to get statistics for"),
),
mcp.WithString("schema",
mcp.Description("Schema name (default: public)"),
mcp.Description(fmt.Sprintf("Schema name (default: %s)", app.DefaultSchema)),
),
)

Expand All @@ -555,7 +555,7 @@ func setupGetTableStatsTool(s *server.MCPServer, appInstance *app.App, debugLogg
}

// Extract schema (optional)
schema := "public"
schema := app.DefaultSchema
if schemaArg, ok := args["schema"].(string); ok && schemaArg != "" {
schema = schemaArg
}
Expand Down
Loading