fix(indexes): use lib/pq array parser for column names with special characters #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…haracters Replace string manipulation (Trim/Split) with pq.StringArray to properly handle PostgreSQL arrays containing column names with special characters. Previous implementation incorrectly split on commas inside quoted identifiers, breaking indexes with columns like "col,with,commas" or "Column Name". Changes: - Use pq.StringArray for scanning PostgreSQL text[] arrays - Remove manual string parsing that failed on edge cases - Add comprehensive test for special characters (spaces, commas, braces) Fixes #26
6 tasks
sgaunet
deleted the
26-fix-postgresql-array-parsing-for-index-columns-with-special-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace string manipulation (Trim/Split) with pq.StringArray to properly
handle PostgreSQL arrays containing column names with special characters.
Previous implementation incorrectly split on commas inside quoted identifiers,
breaking indexes with columns like "col,with,commas" or "Column Name".
Changes:
Fixes #26