perf(tables): optimize ListTables with stats to eliminate N+1 queries #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the N+1 query pattern in ListTables when include_size=true by introducing a single optimized query that joins table metadata with statistics. Changes: - Add ListTablesWithStats method that uses single query with JOIN - Update App.ListTables to use optimized method when stats requested - Add fallback to COUNT(*) for tables with 0 statistics - Configure golangci-lint with higher complexity/length limits - Update tests to use new optimized method Performance improvement: 100+ queries reduced to 1-2 queries for large databases Fixes #21
6 tasks
sgaunet
deleted the
21-fix-n1-query-pattern-in-listtables-with-include_size-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the N+1 query pattern in ListTables when include_size=true
by introducing a single optimized query that joins table metadata with statistics.
Changes:
Performance improvement: 100+ queries reduced to 1-2 queries for large databases
Fixes #21