Update linter version and still observe max line length#355
Update linter version and still observe max line length#355
Conversation
Yes, need to remove local path for the linter... Questions: 1. What's the right prettier setup? 2. Should we put in the rule of max-len
justin808
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 4 unresolved discussions (waiting on @alexfedoseev)
.eslintrc, line 5 at r1 (raw file):
- eslint-config-shakacode - prettier # Not sure if below is better Alex
@alexfedoseev ?
.eslintrc, line 26 at r1 (raw file):
# https://github.com/benmosher/eslint-plugin-import/issues/340 import/no-extraneous-dependencies: 0
@alexfedoseev Thoughts?
package.json, line 12 at r1 (raw file):
"build": "babel --out-dir lib src", "lint": "eslint --ext '*.js,*.test.js' .", "prettier-eslint": "prettier-eslint --ext '*.js,*.test.js' .",
@alexfedoseev should we use this one?
examples/multiple-entries/webpack.dev.config.js, line 14 at r1 (raw file):
'font-awesome-loader', `bootstrap-loader/lib/bootstrap.loader?configFilePath=` + `${__dirname}/bs3.yml!bootstrap-loader/no-op.js`,
in this case, a long line is easier to read, but there are too many cases where this is not the case and long lines are not caught by the linter
alex35mil
left a comment
There was a problem hiding this comment.
I haven't used any of those for quite awhile so my review is not that valuable at this point.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions
|
@justin808 What is blocking this PR? |
|
@justin808 The objective is not clear to me. |
Yes, need to remove local path for the linter...
Questions:
This change is