Skip to content

Commit 41143de

Browse files
Remove redundant RuboCop enable directives for Metrics/CyclomaticComplexity
These enable directives are now unnecessary since their corresponding disable directives were removed in the previous commit. Co-authored-by: Ihab Adham <ihabadham@users.noreply.github.com>
1 parent 8b69a5a commit 41143de

File tree

6 files changed

+0
-11
lines changed

6 files changed

+0
-11
lines changed

react_on_rails/lib/generators/react_on_rails/templates/base/base/bin/switch-bundler

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ class BundlerSwitcher
8585
puts "✅ Removed #{@target_bundler == 'rspack' ? 'webpack' : 'rspack'} dependencies"
8686
File.write(package_json_path, JSON.pretty_generate(package_json))
8787
end
88-
# rubocop:enable Metrics/CyclomaticComplexity
8988

9089
def install_dependencies
9190
puts "📥 Installing #{@target_bundler} dependencies..."
@@ -121,7 +120,6 @@ class BundlerSwitcher
121120

122121
puts "✅ Installed #{@target_bundler} dependencies"
123122
end
124-
# rubocop:enable Metrics/CyclomaticComplexity
125123

126124
def detect_package_manager
127125
return "yarn" if File.exist?("yarn.lock")

react_on_rails/lib/react_on_rails/doctor.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,6 @@ def check_gem_wildcards
489489
# Ignore errors reading Gemfile
490490
end
491491
end
492-
# rubocop:enable Metrics/CyclomaticComplexity
493492

494493
def check_npm_wildcards
495494
return unless File.exist?("package.json")
@@ -512,7 +511,6 @@ def check_npm_wildcards
512511
# Ignore other errors
513512
end
514513
end
515-
# rubocop:enable Metrics/CyclomaticComplexity
516514

517515
def check_key_configuration_files
518516
files_to_check = {
@@ -562,7 +560,6 @@ def check_layout_files
562560
end
563561
end
564562
end
565-
# rubocop:enable Metrics/CyclomaticComplexity
566563

567564
# rubocop:disable Metrics/CyclomaticComplexity
568565
def check_server_rendering_engine
@@ -628,7 +625,6 @@ def check_shakapacker_configuration_details
628625
checker.add_warning(" ⚠️ Could not run 'rake shakapacker:info': #{e.message}")
629626
end
630627
end
631-
# rubocop:enable Metrics/CyclomaticComplexity
632628

633629
def check_react_on_rails_configuration_details
634630
check_react_on_rails_initializer

react_on_rails/lib/react_on_rails/server_rendering_pool/ruby_embedded_java_script.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ def exec_server_render_js(js_code, render_options, js_evaluator = nil)
8686
# We need to parse each chunk and replay the console messages.
8787
result.transform { |chunk| parse_result_and_replay_console_messages(chunk, render_options) }
8888
end
89-
# rubocop:enable Metrics/CyclomaticComplexity
9089

9190
def trace_js_code_used(msg, js_code, file_name = "tmp/server-generated.js", force: false)
9291
return unless ReactOnRails.configuration.trace || force

react_on_rails/lib/react_on_rails/system_checker.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,6 @@ def check_gemfile_version_patterns
570570
# Ignore errors reading Gemfile
571571
end
572572
end
573-
# rubocop:enable Metrics/CyclomaticComplexity
574573

575574
def report_dependency_versions(package_json)
576575
all_deps = package_json["dependencies"]&.merge(package_json["devDependencies"] || {}) || {}
@@ -588,7 +587,6 @@ def report_dependency_versions(package_json)
588587
add_success("✅ React DOM #{react_dom_version}")
589588
end
590589
end
591-
# rubocop:enable Metrics/CyclomaticComplexity
592590

593591
def report_shakapacker_version
594592
return unless File.exist?("Gemfile.lock")

react_on_rails/lib/react_on_rails/utils.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,6 @@ def self.normalize_to_relative_path(path)
494494
path_str
495495
end
496496
end
497-
# rubocop:enable Metrics/CyclomaticComplexity
498497

499498
def self.default_troubleshooting_section
500499
<<~DEFAULT

react_on_rails/lib/react_on_rails/version_checker.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,6 @@ def resolve_version(package_json_version, package_name)
358358
# Fall back to package.json version
359359
package_json_version
360360
end
361-
# rubocop:enable Metrics/CyclomaticComplexity
362361

363362
# Check if a version string represents a local path or URL
364363
def local_path_or_url_version?(version)

0 commit comments

Comments
 (0)