Cast GitHub app_id as string before using as iss#1307
Merged
sigmavirus24 merged 1 commit intosigmavirus24:mainfrom Feb 3, 2026
Merged
Cast GitHub app_id as string before using as iss#1307sigmavirus24 merged 1 commit intosigmavirus24:mainfrom
app_id as string before using as iss#1307sigmavirus24 merged 1 commit intosigmavirus24:mainfrom
Conversation
Contributor
Author
|
Fixes #1306. |
8R0WNI3
added a commit
to gardener/cc-utils
that referenced
this pull request
Feb 2, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
8R0WNI3
added a commit
to open-component-model/delivery-service
that referenced
this pull request
Feb 2, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
sigmavirus24
requested changes
Feb 2, 2026
The pyjwt library expects the issuer to be of type `str` and enforces it with jpadilla/pyjwt#1040. Using an integer as done before will result in `TypeError: Issuer (iss) must be a string.`. Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
sigmavirus24
approved these changes
Feb 3, 2026
8R0WNI3
added a commit
to open-component-model/delivery-service
that referenced
this pull request
Feb 5, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
8R0WNI3
added a commit
to open-component-model/delivery-service
that referenced
this pull request
Feb 5, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
8R0WNI3
added a commit
to open-component-model/delivery-service
that referenced
this pull request
Feb 5, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
8R0WNI3
added a commit
to open-component-model/delivery-service
that referenced
this pull request
Feb 5, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
zkdev
pushed a commit
to gardener/cc-utils
that referenced
this pull request
Feb 5, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
zkdev
pushed a commit
to open-component-model/delivery-service
that referenced
this pull request
Feb 9, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
zkdev
pushed a commit
to open-component-model/delivery-service
that referenced
this pull request
Feb 10, 2026
This is required as long as this upstream fix is not released yet: sigmavirus24/github3.py#1307 Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
|
Hello, sorry for barging in. Do we know when this will be getting released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PyJWT library expects the issuer to be of type
strand enforces it with jpadilla/pyjwt#1040. Using an integer as done before will result inTypeError: Issuer (iss) must be a string..Before opening a new issue, please [search][] for a previously filed
issue to ensure you're not creating a duplicate.
Note Bug reports without the following will receive requests for these
details to be provided.
Version Information
The version of Python you're using:
Python 3.13.9The version of pip you used to install github3.py:
pip 25.3The version of github3.py, requests, uritemplate, and python-dateutil installed:
github3.py 4.0.1Minimum Reproducible Example
Exception information