Skip to content

Fix LT-22355: Crash after typing a letter in Find dialog box #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtmaxwell3 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix LT-22355: Crash after typing a letter in Find dialog box #694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f986fd9
Fix LT-22355: Crash after typing a letter in Find dialog box
jtmaxwell3 Feb 23, 2026
974275b
Report lack of document instead of closing
jtmaxwell3 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Src/xWorks/XhtmlDocView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,6 +1287,11 @@ private void FindNextInBrowser(object sender, IBasicFindView view)

private void ScrollAndHighlightResult(GeckoWebBrowser geckoBrowser, IBasicFindView view, string lastId)
{
if (geckoBrowser.Document == null)
{
view.StatusText = "No Document";
return;
}
if (results != null && results.Length > 0)
{
view.StatusText = $"{resultIndex + 1} of {results.Length} Results";
Expand All @@ -1304,7 +1309,7 @@ private void ScrollAndHighlightResult(GeckoWebBrowser geckoBrowser, IBasicFindVi

private void ClearCurrentFindResult(GeckoWebBrowser geckoBrowser, string lastId)
{
var currentElement = geckoBrowser.Document.GetHtmlElementById(lastId);
var currentElement = geckoBrowser.Document?.GetHtmlElementById(lastId);
if (currentElement != null)
docView.RemoveClassFromHtmlElement(currentElement, CurrentSelectedEntryClass);
}
Expand All @@ -1317,6 +1322,12 @@ private bool InitResults(string searchText)
if (results == null || results.Length == 0)
{
string newResults = string.Empty;
if (geckoBrowser.Document == null)
{
results = newResults.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries);
resultIndex = 0;
return true;
}
geckoBrowser.RemoveMessageEventListener("find");
geckoBrowser.AddMessageEventListener("find", r => newResults = r);
using(var executor = new AutoJSContext(geckoBrowser.Window))
Expand Down
Loading