SF-3710 Do not autoselect translate books when starting a draft#3701
SF-3710 Do not autoselect translate books when starting a draft#3701RaymondLuong3 wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3701 +/- ##
==========================================
- Coverage 81.74% 81.74% -0.01%
==========================================
Files 619 619
Lines 38663 38654 -9
Branches 6297 6294 -3
==========================================
- Hits 31606 31597 -9
Misses 6096 6096
Partials 961 961 ☔ View full report in Codecov by Sentry. |
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on RaymondLuong3).
-- commits line 2 at r1:
Can you rephrase this? Even after knowing what this PR was about, it took me a lot of effort and concentration to figure out how this title had anything to do with the task at hand, because I read it as "Get all the translate book options"..., and just couldn't figure out what it was trying to say.
b6dbab9 to
ae2094b
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 made 1 comment and resolved 1 discussion.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on Nateowami).
Previously, Nateowami wrote…
Can you rephrase this? Even after knowing what this PR was about, it took me a lot of effort and concentration to figure out how this title had anything to do with the task at hand, because I read it as "Get all the translate book options"..., and just couldn't figure out what it was trying to say.
Sure, I'll rephrase this.
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 1 file and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).
Previously, RaymondLuong3 (Raymond Luong) wrote…
Sure, I'll rephrase this.
Thanks. I also updated the PR title.
This PR removes the auto selection feature for translation books on the draft generation wizard.
This change is