Skip to content

Comments

SF-3710 Do not autoselect translate books when starting a draft#3701

Open
RaymondLuong3 wants to merge 1 commit intomasterfrom
task/sf-3710-auto-select
Open

SF-3710 Do not autoselect translate books when starting a draft#3701
RaymondLuong3 wants to merge 1 commit intomasterfrom
task/sf-3710-auto-select

Conversation

@RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Feb 19, 2026

This PR removes the auto selection feature for translation books on the draft generation wizard.


This change is Reviewable


Open with Devin

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.74%. Comparing base (595481b) to head (ae2094b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3701      +/-   ##
==========================================
- Coverage   81.74%   81.74%   -0.01%     
==========================================
  Files         619      619              
  Lines       38663    38654       -9     
  Branches     6297     6294       -3     
==========================================
- Hits        31606    31597       -9     
  Misses       6096     6096              
  Partials      961      961              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nateowami reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on RaymondLuong3).


-- commits line 2 at r1:
Can you rephrase this? Even after knowing what this PR was about, it took me a lot of effort and concentration to figure out how this title had anything to do with the task at hand, because I read it as "Get all the translate book options"..., and just couldn't figure out what it was trying to say.

@RaymondLuong3 RaymondLuong3 force-pushed the task/sf-3710-auto-select branch from b6dbab9 to ae2094b Compare February 20, 2026 17:06
Copy link
Collaborator Author

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 made 1 comment and resolved 1 discussion.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on Nateowami).


-- commits line 2 at r1:

Previously, Nateowami wrote…

Can you rephrase this? Even after knowing what this PR was about, it took me a lot of effort and concentration to figure out how this title had anything to do with the task at hand, because I read it as "Get all the translate book options"..., and just couldn't figure out what it was trying to say.

Sure, I'll rephrase this.

@Nateowami Nateowami changed the title SF-3710 Get all translate book options to initialize unselected SF-3710 Do not autoselect translate books when starting a draft Feb 20, 2026
Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 1 file and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).


-- commits line 2 at r1:

Previously, RaymondLuong3 (Raymond Luong) wrote…

Sure, I'll rephrase this.

Thanks. I also updated the PR title.

@Nateowami Nateowami added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Feb 20, 2026
@Nateowami Nateowami self-assigned this Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants