SeaCharts v4.0 #45
Open
SeaCharts v4.0 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes for autosize
S-57 base functionality implementation
…dle northern and southern projection
updated configuration for different utm zones, display should now han…
added unit display to colorbar
Fix weather access
shallow waters are not underlapping whole map now
loading shapefiles simplified
Get records in layer
Utility updates
* Update README.md - features * Update README.md * Update README.md - usage * Update README.md - image * image added * image * image * Update README.md * Update README.md --------- Co-authored-by: miqn <109998643+meeqn@users.noreply.github.com>
* added some description for users running SC for the first time * upgraded test file and parametrized coastline display
* added some description for users running SC for the first time * upgraded test file and parametrized coastline display * seacharts 4 setup tips added
* added some description for users running SC for the first time * upgraded test file and parametrized coastline display * seacharts 4 setup tips added * Generated descriptions for most of the code and few refactors
* add weather utility function * Update config.yaml * Update config.yaml * Update config.yaml
* minor fixes regarding setup and documentation * simplified testing files
* Refactor configuration schema and core classes for improved clarity and functionality. Use CoordTuple for XY paired data in Extent class - it notably improves readability and thus maintainability. In the future these types of coordinates and bounding boxes could be replaced with similar, more readable containers. Changelog: - Updated comments in config_schema.yaml for better understanding of parameters. - Enhanced Config class to support optional config_path parameter. - Introduced CoordTuple class in extent.py for better handling of 2D coordinates. - Modified methods in extent.py to utilize CoordTuple for size, origin, and center. - Adjusted ENC class to return coordinates as tuples from extent. - Cleaned up imports and removed unused code in various files. - Improved type hints across multiple classes for better code readability. * Enhance directory structure creation and improve error handling for layer retrieval * Remove unused autosize option from config schema
* Fixed some issues based on Copilot-generated review. - Added a check in `build_directory_structure` to raise a ValueError if the source root name is None. - Updated `get_source_root_name` method signatures in `DataParser`, `FGDBParser`, and `S57Parser` to indicate they can return None. - Modified return values in `FGDBParser` and `S57Parser` to return None when no valid data is found. - Improved docstrings for clarity on return types and conditions. * Fix the false positive scenarios in control panel creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Major changes
Minor changes: