sse4.2: first attempt at implementing mm_cmpestra#280
sse4.2: first attempt at implementing mm_cmpestra#280masterchef2209 wants to merge 14 commits intosimd-everywhere:masterfrom
Conversation
|
please tell me if I am going in right direction in implementation of the function and generating test cases. |
nemequ
left a comment
nemequ
left a comment
There was a problem hiding this comment.
This is a good start. A lot of the issues I see right away are relatively minor, but hopefully they'll make the code a little easier to understand, which should make it easier to optimize in the future.
|
Thank You for the review, it will take some time to go through all of this :) |
mr-c
left a comment
mr-c
left a comment
There was a problem hiding this comment.
Almost there! Another issue from https://github.com/nemequ/simde/pull/280/checks?check_run_id=662532291#step:5:66
|
That is odd, Travis CI hasn't seen the latest commit .. |
nemequ
left a comment
nemequ
left a comment
There was a problem hiding this comment.
Excellent progress! I added some more comments, but don't get discouraged. These functions are definitely a bit of a pani to implement (which is a big part of why they're not implemented yet), and you're doing really well. I just want to be a bit pedantic about this first function since it's probably going to be a model for the others.
I've tried to explain the reasons for each change, but if there is anything you're not clear on please ask.
masterchef2209
force-pushed
the
hidayat/may10_1
branch
from
fc0618d to
cfe4b7f
Compare
|
The implementation looks good to me. As soon as you have the tests done we can merge it. |
I am working on it, hopefully I will be able to finish it by today. |
|
Closing in favor of #295 |
4 participants
sse4.2: first attempt at implementing mm_cmpestra