-
-
Notifications
You must be signed in to change notification settings - Fork 123
Drop Python 3.9, test against Python 3.14 preview #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cog test failed in CI, but these are case insensitive anyway.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
- Coverage 95.60% 95.46% -0.15%
==========================================
Files 8 8
Lines 2915 2930 +15
==========================================
+ Hits 2787 2797 +10
- Misses 128 133 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| def _value_or_none(value): | ||
| if getattr(value, "__class__", None).__name__ == "Sentinel": | ||
| return None | ||
| return value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex CLI on GPT-5-Codex suggested this as a workaround for:
|
It looks like that gross |
|
I'm going to land this and file a separate ticket to remove the Sentinel hack once Click ship their next version. |
📚 Documentation preview 📚: https://sqlite-utils--665.org.readthedocs.build/en/665/