Skip to content

Conversation

@simonw
Copy link
Owner

@simonw simonw commented Oct 1, 2025

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.46%. Comparing base (094b010) to head (6d96dc2).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
sqlite_utils/cli.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   95.60%   95.46%   -0.15%     
==========================================
  Files           8        8              
  Lines        2915     2930      +15     
==========================================
+ Hits         2787     2797      +10     
- Misses        128      133       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simonw simonw changed the title Run tests against Python 3.14 preview Drop Python 3.9, test against Python 3.14 preview Oct 1, 2025
Comment on lines +3296 to +3299
def _value_or_none(value):
if getattr(value, "__class__", None).__name__ == "Sentinel":
return None
return value
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex CLI on GPT-5-Codex suggested this as a workaround for:

@simonw
Copy link
Owner Author

simonw commented Oct 1, 2025

It looks like that gross Sentinel hack will become unnecessary once Click 8.3.1 is released with their fix to this issue:

@simonw
Copy link
Owner Author

simonw commented Oct 1, 2025

I'm going to land this and file a separate ticket to remove the Sentinel hack once Click ship their next version.

@simonw simonw merged commit c479ca0 into main Oct 1, 2025
106 checks passed
@simonw simonw deleted the python-3.14 branch October 1, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants