README: Recommend using Regexp filters for add_group#1062
Open
splattael wants to merge 1 commit intosimplecov-ruby:mainfrom
Open
README: Recommend using Regexp filters for add_group#1062splattael wants to merge 1 commit intosimplecov-ruby:mainfrom
add_group#1062splattael wants to merge 1 commit intosimplecov-ruby:mainfrom
Conversation
33cbb8e to
574b45c
Compare
4bf967b to
666efd1
Compare
Contributor
Author
Using String filters can include wrong files to groups because it
matches if the string is contained within the path.
For example:
# This matches files like `./lib/foo.rb`
# but also `./app/models/library.rb'
add_group 'Libraries', 'lib'
# Prefer Regexp filter instead:
add_group 'Libraries', %r{^/lib/}
666efd1 to
a15f582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using String filters can include wrong files to groups because it matches if the string is contained within the path.
For example:
See also https://gitlab.com/gitlab-org/gitlab/-/issues/416910
Alternative
Instead, we could adjust the String filter to use
start_with?instead ofinclude?but that'd be a breaking change and also require users to prepend a leading slash to their configuration like: