ignore nil branches during parallel combine#1081
Open
shixianyangidme wants to merge 1 commit intosimplecov-ruby:mainfrom
Open
ignore nil branches during parallel combine#1081shixianyangidme wants to merge 1 commit intosimplecov-ruby:mainfrom
shixianyangidme wants to merge 1 commit intosimplecov-ruby:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue had very similar cause of another pending PR: , but it is caused by parallel test. My project is based on ruby 3.1.4
If a parallel test (2 processes) generates two results on the same file:
Result A
"/Users/shixian.yang/workspace/test.rb": { "lines": [ 1, 1, null ] },Result B
"/Users/shixian.yang/workspace/test.rb": { "lines": [ 0, 0, null ] },Neither of results have "branches", the merge will generate a
"branches": nilas a result. Finally it ends up in the errorNoMethodError: undefined method `flat_map' for nil:NilClass.
My plan is to ignore the "branches" field if neither A and B have "branches" exist.