SSP-2060-Use_processing_chain #43
Conversation
…Factories directory.
pradtke
left a comment
pradtke
left a comment
There was a problem hiding this comment.
I had some minor questions, and I think some files aren't needed.
I was able to test with preprod warning module.
composer.json
Outdated
| "simplesamlphp/xml-common": "^1.16", | ||
| "simplesamlphp/xml-soap": "^1.4" | ||
| "simplesamlphp/xml-cas": "^v1.3", | ||
| "simplesamlphp/xml-common": "^v1.18", |
There was a problem hiding this comment.
is upgrading the xml-common library needed? I'm asking since the version in the composer.lock for ssp 2.3.2 full is v1.17.2 and our (Cirrus's) general preference is to be able to install modules into the full version without needing to upgrade any packages already in the lock file.
Are upgrading the other packages needed?
There was a problem hiding this comment.
I was targeting the ssp 2.4 release this is why i used the v1.18. I will fallback to ssp 2.3.x and thus use v1.17.
Are upgrading the other packages needed?
the xml-cas package introduces the new attributes. We are discussing about this in the other thread.
the xml-soap has a different directory structure and still supports the soap1.1 and soap1.2. This PR still uses soap1.1
There was a problem hiding this comment.
oh, so if we target xml-soap 1.4 will it still work with xml-soap 1.5? e.g. can we target ssp 2.3 and still have it work with 2.4?
There was a problem hiding this comment.
oh, so if we target xml-soap 1.4 will it still work with xml-soap 1.5? e.g. can we target ssp 2.3 and still have it work with 2.4?
I do not think i understand the question.
Currently i am developing and testing against ssp 2.3.x but the module targets xml-soap 1.5. The login flows works correctly. Also the composer does not complain. Code wise the main change is the namespaces. Previously they were .../SOAP11/... while now they are .../env_200106/....
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
| "live" in the container, allowing you to test and iterate different things. | ||
|
|
||
| ```bash | ||
| # Note: this currently errors on this module requiring a newer version of `simplesamlphp/xml-common` than what is in the base image |
There was a problem hiding this comment.
This should be solved in SSP 2.3.3
|
Ignore the failing documentation-action.. It has been resolved in |
ioigoume
force-pushed
the
SSP-2060-Use_processing_chain
branch
from
794e47f to
c59c5ce
Compare
|
Scrutinizer has found a couple of relevant issues: |
Fixed |
3 participants
No description provided.