Handle gateway query parameter at login #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradtke
reviewed
Oct 18, 2025
| * redirect immediately to the service URL with NO query parameters or fragment. | ||
| */ | ||
| if ($gateway === true && $serviceUrl !== null && !$this->authSource->isAuthenticated()) { | ||
| $cleanServiceUrl = $this->stripQueryParameters($serviceUrl); |
Collaborator
There was a problem hiding this comment.
This doesn't line up with my reading of the spec. I don't think you need to manipulate the service url. The service url is allowed to have query parameters. I think the spec just says "do not add a ticket query parameter" and redirect the user to that serviceUrl.
From https://apereo.github.io/cas/7.3.x/protocol/CAS-Protocol-Specification.html
If the client does not have a single sign-on session with CAS, and a non-interactive authentication cannot be established, CAS MUST redirect the client to the URL specified by the service parameter with no “ticket” parameter appended to the URL.
Member
There was a problem hiding this comment.
I read it the same way.. Just the ticket-param should be stripped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.