Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • change add inputs button to match output selector

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs Ready Ready Preview, Comment Jan 21, 2026 2:57am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 21, 2026

Greptile Summary

This PR replaces the Badge component with custom div elements to make the "Add inputs" buttons visually consistent with the OutputSelect component styling.

  • Replaced Badge variant='outline' with custom div using hardcoded Combobox-style classes in chat.tsx and a2a.tsx
  • Updated button styling to match OutputSelect/Combobox trigger appearance (rounded-[6px], same padding, colors, and hover states)
  • Removed unused Badge import from a2a.tsx
  • bun.lock updated with configVersion field

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk
  • The changes are purely cosmetic UI updates that replace a component with hardcoded styling. The implementation correctly matches the target styling and the functionality remains unchanged. The only minor issue is an unused import in chat.tsx
  • Check chat.tsx for the unused Badge import

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/chat.tsx Replaced Badge component with custom div to match OutputSelect styling; unused import remains
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/a2a/a2a.tsx Replaced Badge component with custom div to match OutputSelect styling; properly removed unused import

Sequence Diagram

sequenceDiagram
    participant User
    participant ChatUI as Chat UI
    participant A2AUI as A2A Deploy UI
    participant StartBlock as Start Block

    Note over ChatUI,A2AUI: UI Rendering Phase
    
    User->>ChatUI: View chat interface
    ChatUI->>ChatUI: Check shouldShowConfigureStartInputsButton
    alt Missing Start Inputs
        ChatUI->>User: Display "Add inputs" button (custom div)
        User->>ChatUI: Click "Add inputs"
        ChatUI->>StartBlock: handleConfigureStartInputs()
        StartBlock-->>ChatUI: Configure inputs
    end
    
    User->>A2AUI: View A2A deployment settings
    A2AUI->>A2AUI: Check missingFields.any
    alt Missing A2A Fields
        A2AUI->>User: Display "Add inputs" button (custom div)
        User->>A2AUI: Click "Add inputs"
        A2AUI->>StartBlock: handleAddA2AInputs()
        StartBlock-->>A2AUI: Add A2A fields
    end
    
    Note over ChatUI,A2AUI: Both buttons now match OutputSelect styling
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/chat.tsx, line 15 (link)

    style: Remove unused Badge import

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 16716ea into staging Jan 21, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/ui branch January 21, 2026 03:25
waleedlatif1 added a commit that referenced this pull request Jan 21, 2026
* fix(google): wrap primitive tool responses for Gemini API compatibility (#2900)

* fix(canonical): copilot path + update parent (#2901)

* fix(rss): add top-level title, link, pubDate fields to RSS trigger output (#2902)

* fix(rss): add top-level title, link, pubDate fields to RSS trigger output

* fix(imap): add top-level fields to IMAP trigger output

* improvement(browseruse): add profile id param (#2903)

* improvement(browseruse): add profile id param

* make request a stub since we have directExec

* improvement(executor): upgraded abort controller to handle aborts for loops and parallels (#2880)

* improvement(executor): upgraded abort controller to handle aborts for loops and parallels

* comments

* improvement(files): update execution for passing base64 strings (#2906)

* progress

* improvement(execution): update execution for passing base64 strings

* fix types

* cleanup comments

* path security vuln

* reject promise correctly

* fix redirect case

* remove proxy routes

* fix tests

* use ipaddr

* feat(tools): added textract, added v2 for mistral, updated tag dropdown (#2904)

* feat(tools): added textract

* cleanup

* ack pr comments

* reorder

* removed upload for textract async version

* fix additional fields dropdown in editor, update parser to leave validation to be done on the server

* added mistral v2, files v2, and finalized textract

* updated the rest of the old file patterns, updated mistral outputs for v2

* updated tag dropdown to parse non-operation fields as well

* updated extension finder

* cleanup

* added description for inputs to workflow

* use helper for internal route check

* fix tag dropdown merge conflict change

* remove duplicate code

---------

Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

* fix(ui): change add inputs button to match output selector (#2907)

* fix(canvas): removed invite to workspace from canvas popover (#2908)

* fix(canvas): removed invite to workspace

* removed unused props

* fix(copilot): legacy tool display names (#2911)

* fix(a2a): canonical merge  (#2912)

* fix canonical merge

* fix empty array case

* fix(change-detection): copilot diffs have extra field (#2913)

* improvement(logs): improved logs ui bugs, added subflow disable UI (#2910)

* improvement(logs): improved logs ui bugs, added subflow disable UI

* added duplicate to action bar for subflows

* feat(broadcast): email v0.5 (#2905)

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants