Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • removed invite to workspace from canvas popover

Type of Change

  • Bug fix

Testing

N/A

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 21, 2026 4:19am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 21, 2026

Greptile Summary

Removed the "Invite to Workspace" menu item from the canvas right-click context menu. The PR also includes minor CSS class reordering in two other files for better code organization.

Key changes:

  • Removed invite functionality from canvas context menu (canvas-menu.tsx)
  • Reordered Tailwind CSS classes for consistency (chat.tsx, a2a.tsx)

Issues found:

  • Unused props (onInvite, isInvitationsDisabled, disableAdmin) remain in the CanvasMenu component interface and are still being passed from the parent component (workflow.tsx)

Confidence Score: 4/5

  • Safe to merge with minor cleanup recommended
  • The functional change (removing invite menu item) is straightforward and won't break anything. However, unused props should be cleaned up to maintain code quality.
  • canvas-menu.tsx has unused props that should be removed in a follow-up

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/canvas-menu/canvas-menu.tsx Removed "Invite to Workspace" menu item from canvas context menu, but left unused props in interface

Sequence Diagram

sequenceDiagram
    participant User
    participant Canvas
    participant CanvasMenu
    participant Workflow
    
    User->>Canvas: Right-click on empty canvas
    Canvas->>CanvasMenu: Open context menu
    CanvasMenu->>User: Display menu options
    Note over CanvasMenu: "Invite to Workspace" removed
    User->>CanvasMenu: Select menu action
    CanvasMenu->>Workflow: Execute action (e.g., onAddBlock, onAutoLayout)
    Note over Workflow: onInvite handler no longer called
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (3)

  1. apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/canvas-menu/canvas-menu.tsx, line 29 (link)

    style: onInvite prop no longer used after removing the invite menu item

  2. apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/canvas-menu/canvas-menu.tsx, line 37 (link)

    style: isInvitationsDisabled prop no longer used

  3. apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/canvas-menu/canvas-menu.tsx, line 58-66 (link)

    style: Remove unused props from destructuring

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

3 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit c6d408c into staging Jan 21, 2026
11 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/canvas branch January 21, 2026 04:29
waleedlatif1 added a commit that referenced this pull request Jan 21, 2026
* fix(google): wrap primitive tool responses for Gemini API compatibility (#2900)

* fix(canonical): copilot path + update parent (#2901)

* fix(rss): add top-level title, link, pubDate fields to RSS trigger output (#2902)

* fix(rss): add top-level title, link, pubDate fields to RSS trigger output

* fix(imap): add top-level fields to IMAP trigger output

* improvement(browseruse): add profile id param (#2903)

* improvement(browseruse): add profile id param

* make request a stub since we have directExec

* improvement(executor): upgraded abort controller to handle aborts for loops and parallels (#2880)

* improvement(executor): upgraded abort controller to handle aborts for loops and parallels

* comments

* improvement(files): update execution for passing base64 strings (#2906)

* progress

* improvement(execution): update execution for passing base64 strings

* fix types

* cleanup comments

* path security vuln

* reject promise correctly

* fix redirect case

* remove proxy routes

* fix tests

* use ipaddr

* feat(tools): added textract, added v2 for mistral, updated tag dropdown (#2904)

* feat(tools): added textract

* cleanup

* ack pr comments

* reorder

* removed upload for textract async version

* fix additional fields dropdown in editor, update parser to leave validation to be done on the server

* added mistral v2, files v2, and finalized textract

* updated the rest of the old file patterns, updated mistral outputs for v2

* updated tag dropdown to parse non-operation fields as well

* updated extension finder

* cleanup

* added description for inputs to workflow

* use helper for internal route check

* fix tag dropdown merge conflict change

* remove duplicate code

---------

Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

* fix(ui): change add inputs button to match output selector (#2907)

* fix(canvas): removed invite to workspace from canvas popover (#2908)

* fix(canvas): removed invite to workspace

* removed unused props

* fix(copilot): legacy tool display names (#2911)

* fix(a2a): canonical merge  (#2912)

* fix canonical merge

* fix empty array case

* fix(change-detection): copilot diffs have extra field (#2913)

* improvement(logs): improved logs ui bugs, added subflow disable UI (#2910)

* improvement(logs): improved logs ui bugs, added subflow disable UI

* added duplicate to action bar for subflows

* feat(broadcast): email v0.5 (#2905)

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants