-
Notifications
You must be signed in to change notification settings - Fork 3.2k
v0.5.66: external http requests fix, ring highlighting #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* fix(http): options not parsed accurately * fix lint * remove boilerplate code'
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryFixed the Key Changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as Tool Executor
participant Validator as validateUrlWithDNS
participant DNS as DNS Resolver
participant Fetch as secureFetchWithPinnedIP
participant Agent as HTTP/HTTPS Agent
participant Server as External Server
Client->>Validator: validateUrlWithDNS(url)
Validator->>DNS: dns.lookup(hostname)
DNS-->>Validator: resolvedIP
Validator->>Validator: Check if IP is private/reserved
Validator-->>Client: {isValid, resolvedIP}
Client->>Fetch: secureFetchWithPinnedIP(url, resolvedIP, options)
Fetch->>Fetch: Create lookup function with pinned IP
Note over Fetch: lookup handles options.all case:<br/>returns [{address, family}] or (address, family)
Fetch->>Fetch: Remove accept-encoding header
Fetch->>Agent: Create Agent with custom lookup
Fetch->>Server: HTTP/HTTPS request with pinned IP
Note over Agent,Server: Agent uses lookup function<br/>to force connection to resolvedIP
Server-->>Fetch: Response
Fetch-->>Client: SecureFetchResponse
|
* fix(ring): duplicate should clear original block * rename correctly
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Summary