fix(auth): improve reset password flow and consolidate brand detection

[waleedlatif1]

Summary

• Add password reset success message on login page
• Consolidate duplicated brand detection logic into useBrandedButtonClass hook across all auth forms
• Add special character requirement to backend password validation
• Improve login error handling with errorHandled flag pattern

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Jan 21, 2026 10:18pm

[greptile-apps]

Greptile Summary

Improved the password reset user experience by adding a success message on the login page after password reset, and consolidated duplicated brand detection logic across all auth forms into a reusable useBrandedButtonClass hook.

Key Changes:

• Added resetSuccessMessage state to display password reset success on login page, cleared on login errors or successful authentication
• Improved login error handling with errorHandled flag to prevent duplicate error messages from fallback handler
• Extracted brand detection logic (checking --brand-accent-hex CSS variable) into useBrandedButtonClass hook, removing ~30 lines of duplicate code from each of 5 auth forms
• Added special character requirement to backend password validation schema to match frontend validation
• Added explicit redirect fallback after successful login

Issues Found:

• Uncaught errors in the login catch block don't display user-facing error messages

Confidence Score: 4/5

• This PR is safe to merge with one minor issue to address
• The changes successfully consolidate duplicate code and improve UX with proper password reset feedback. The hook extraction follows React best practices. However, there's one logical issue where uncaught errors in the login catch block don't show user-facing messages, leaving users without feedback on unexpected errors.
• Pay attention to apps/sim/app/(auth)/login/login-form.tsx for the uncaught error handling fix

Important Files Changed

Filename	Overview
apps/sim/app/(auth)/login/login-form.tsx	Added reset success message display and improved error handling with errorHandled flag pattern; consolidated brand detection into hook
apps/sim/app/api/auth/reset-password/route.ts	Added special character requirement to password validation schema

Sequence Diagram

sequenceDiagram
    participant User
    participant ResetPage as Reset Password Page
    participant API as /api/auth/reset-password
    participant LoginPage as Login Page
    
    User->>ResetPage: Enter new password + token
    ResetPage->>ResetPage: Validate password (8-100 chars, uppercase, lowercase, number, special char)
    ResetPage->>API: POST with token + newPassword
    API->>API: Validate password schema (same rules + special char)
    API-->>ResetPage: Success
    ResetPage->>LoginPage: Redirect with ?resetSuccess=true
    LoginPage->>LoginPage: Display success message
    User->>LoginPage: Sign in with new password
    LoginPage->>LoginPage: Clear success message on error
    LoginPage->>LoginPage: Clear success message on successful login

Loading

[greptile-apps]

_{6 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

[waleedlatif1]

@greptile

[greptile-apps]

Additional Comments (1)

1. apps/sim/app/(auth)/login/login-form.tsx, line 295 (link)

   logic: uncaught errors in the catch block should show error messages to the user

   _{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

_{6 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}