Skip to content

fix(null-bodies): empty bodies handling #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 2 commits into from
Jan 22, 2026
+16 −9
Merged

fix(null-bodies): empty bodies handling #2931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7d08f2
fix(null-statuses): empty bodies handling
icecrasher321 Jan 22, 2026
58c8926
address bugbot comment
icecrasher321 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions apps/sim/tools/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,13 +643,22 @@ async function executeToolRequest(
})

const responseHeaders = new Headers(secureResponse.headers.toRecord())
const bodyBuffer = await secureResponse.arrayBuffer()
const nullBodyStatuses = new Set([101, 204, 205, 304])

response = new Response(bodyBuffer, {
status: secureResponse.status,
statusText: secureResponse.statusText,
headers: responseHeaders,
})
if (nullBodyStatuses.has(secureResponse.status)) {
response = new Response(null, {
status: secureResponse.status,
statusText: secureResponse.statusText,
headers: responseHeaders,
})
} else {
const bodyBuffer = await secureResponse.arrayBuffer()
response = new Response(bodyBuffer, {
status: secureResponse.status,
statusText: secureResponse.statusText,
headers: responseHeaders,
})
}
}

// For non-OK responses, attempt JSON first; if parsing fails, fall back to text
Expand Down Expand Up @@ -693,11 +702,9 @@ async function executeToolRequest(
throw errorToTransform
}

// Parse response data once with guard for empty 202 bodies
let responseData
const status = response.status
if (status === 202) {
// Many APIs (e.g., Microsoft Graph) return 202 with empty body
if (status === 202 || status === 204 || status === 205) {
responseData = { status }
} else {
if (tool.transformResponse) {
Expand Down