-
Notifications
You must be signed in to change notification settings - Fork 28
MULTIARCH-5587: Enabling power arch image builds for v2 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Enabling plano tool for image builds * Added new github action workflow files for frontend and backend * updated python version in Containerfiles as tag alpine uses updated python v3.14 Signed-off-by: Kaushik Talathi <kaushik.talathi1@ibm.com>
7f96a96 to
cab9fb5
Compare
| run: | | ||
| echo "${{ secrets.QUAY_TOKEN }}" | docker login quay.io -u "${{ secrets.QUAY_USER }}" --password-stdin | ||
| - name: Build and Push Multi-Arch Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| run: | | |
| echo "${{ secrets.QUAY_TOKEN }}" | docker login quay.io -u "${{ secrets.QUAY_USER }}" --password-stdin | |
| - name: Build and Push Multi-Arch Image | |
| run: | | |
| echo "${{ secrets.QUAY_TOKEN }}" | docker login quay.io -u "${{ secrets.QUAY_USER }}" --password-stdin | |
| - name: Build and Push Multi-Arch Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small formatting to make slightly more readable
| echo "${{ secrets.QUAY_TOKEN }}" | docker login quay.io -u "${{ secrets.QUAY_USER }}" --password-stdin | ||
| - name: Build and Push Multi-Arch Image | ||
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| echo "${{ secrets.QUAY_TOKEN }}" | docker login quay.io -u "${{ secrets.QUAY_USER }}" --password-stdin | |
| - name: Build and Push Multi-Arch Image | |
| run: | | |
| echo "${{ secrets.QUAY_TOKEN }}" | docker login quay.io -u "${{ secrets.QUAY_USER }}" --password-stdin | |
| - name: Build and Push Multi-Arch Image | |
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small formatting to make slightly more readable
| run(f"podman manifest rm {image_tag}", check=False) | ||
| run(f"podman rmi {image_tag}", check=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addition is only needed true outside of a workflow.
| run(f"podman manifest rm {image_tag}", check=False) | ||
| run(f"podman rmi {image_tag}", check=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as earlier... This addition is only needed true outside of a workflow.
| run(f"podman build {no_cache_arg} --format docker -t {image_tag} .") | ||
| run(f"podman manifest rm {image_tag}", check=False) | ||
| run(f"podman rmi {image_tag}", check=False) | ||
| run(f"podman build {no_cache_arg} --format docker --platform linux/amd64,linux/arm64,linux/s390x,linux/ppc64le --file frontend/Containerfile --manifest {image_tag} ./frontend") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
| run(f"podman build {no_cache_arg} --format docker -t {image_tag} .") | ||
| run(f"podman manifest rm {image_tag}", check=False) | ||
| run(f"podman rmi {image_tag}", check=False) | ||
| run(f"podman build {no_cache_arg} --format docker --platform linux/amd64,linux/arm64,linux/s390x,linux/ppc64le --file backend/Containerfile --manifest {image_tag} ./backend") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
| USER fritz | ||
|
|
||
| COPY --from=build /usr/local/lib/python3.12/site-packages /usr/local/lib/python3.12/site-packages | ||
| COPY --from=build /usr/local/lib/python3.14/site-packages /usr/local/lib/python3.14/site-packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just add a comment telling why inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a review comment
This PR contains changes as follows:
I'm verifying Skupper on Power for MULTIARCH-5587
Details of successful validations of workflow files with custom images built -
CC: @prb112, @mjturek & @hash-d