Skip to content

feat: Change output name to search_results #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cchensh merged 1 commit into from
Jan 8, 2026
Merged

feat: Change output name to search_results #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion listeners/functions/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def search_step_callback(
for sample in samples
]

complete(outputs={"search_result": results})
complete(outputs={"search_results": results})
except Exception as e:
if isinstance(e, SlackResponseError):
logger.error(f"Failed to fetch or parse sample data. Error details: {str(e)}", exc_info=e)
Expand Down
4 changes: 2 additions & 2 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@
}
},
"output_parameters": {
"search_result": {
"search_results": {
"type": "slack#/types/search_results",
"title": "Search Result",
"description": "An array containing the search results based on the inputs",
"is_required": true,
"name": "search_result"
"name": "search_results"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions tests/listeners/functions/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def test_search_step_callback_success(self, mock_fetch_sample_data):
call_args = self.mock_complete.call_args
outputs = call_args.kwargs["outputs"]

assert outputs["search_result"] == self.mock_sample_data["samples"]
assert outputs["search_results"] == self.mock_sample_data["samples"]

self.mock_ack.assert_called_once()
self.mock_fail.assert_not_called()
Expand Down Expand Up @@ -117,7 +117,7 @@ def test_search_step_callback_no_filters(self, mock_fetch_sample_data):
self.mock_complete.assert_called_once()
call_args = self.mock_complete.call_args
outputs = call_args.kwargs["outputs"]
assert outputs["search_result"] == []
assert outputs["search_results"] == []

self.mock_ack.assert_called_once()

Expand Down