test: add tests around the logger experience of bolt#1270
Merged
WilliamBergamin merged 3 commits intomainfrom Mar 13, 2025
Merged
test: add tests around the logger experience of bolt#1270WilliamBergamin merged 3 commits intomainfrom
WilliamBergamin merged 3 commits intomainfrom
Conversation
zimeg
approved these changes
Mar 13, 2025
Member
zimeg
left a comment
There was a problem hiding this comment.
LGTM! These are great cases to be covering 🙏
AFAICT this confirms the same logger is used for both the Bolt and WebClient instance, as is, but doesn't change how the logger might be shared in logic?
The linked issue's case isn't so obvious in these tests, but as a first step I'm a fan of these tests 🧪 🔍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 90.94% 90.96% +0.01%
==========================================
Files 222 222
Lines 7501 7501
==========================================
+ Hits 6822 6823 +1
+ Misses 679 678 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to add tests around the behavior of loggers used between
BoltandWebClientThis is the first step to solve #1255
Testing
Run the unit tests
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.