-
Notifications
You must be signed in to change notification settings - Fork 678
feat(cli-hooks): add default app and manifest watch config #2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: zimeg-fix-hooks-daemon
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## zimeg-fix-hooks-daemon #2480 +/- ##
==========================================================
+ Coverage 93.10% 93.11% +0.01%
==========================================================
Files 40 40
Lines 11250 11269 +19
Branches 713 713
==========================================================
+ Hits 10474 10493 +19
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting times!
packages/cli-hooks/src/get-hooks.js
Outdated
| paths: ['.'], | ||
| app: { | ||
| paths: ['.'], | ||
| 'filter-regex': '.js$', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I think we should also support .ts for TypeScript developers using Bolt JS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks We might use the built changes from tsc for now, though these changes might be good to document as well!
A note on this is mentioned now in the CHANGELOG and also updates to the sample app:
| TypeScript developers should run `tsc --watch` in a separate terminal during development. This compiles `.ts` files to `.js` on changes, and the default watch configuration will detect changes to the compiled `dist/*.js` files and restart the app server. This approach works best with the default settings. |
🦋 Changeset detectedLatest commit: 5fcd109 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🏷️ Follows: slackapi/slack-cli#310 |
Summary
This PR adds a default
appandmanifestoption to file watching for server restarts and app reinstalls.Requirements