-
Notifications
You must be signed in to change notification settings - Fork 678
build: fix package format for publishing and reviewing releases in workflow #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2492 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 40 40
Lines 11239 11239
Branches 713 713
=======================================
Hits 10463 10463
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WilliamBergamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great 🚀
|
@WilliamBergamin I think so too 🐌 ✨ Let's merge this after tests run to see soon if a release of |
|
👁️🗨️ note: The
🪬 issue: But the "ignore" field didn't seem to stop an attempt of publishing "@slack/cli-test" which causes error... node-slack-sdk/.changeset/config.json Line 10 in d84f894
🔗 https://github.com/slackapi/node-slack-sdk/actions/runs/21529950836/job/62043381449 |

Summary
This PR follows #2483 with a handful of fixes to remove known errors in CI 🤖
🎁 Fixes to package metadata
A change to package metadata for the "publish" step was made using the following command:
📺 Removing automatic publishing for
@slack/cli-testThe
@slack/cli-testpackage is also ignored from the release workflow for now and adjacent issue are noted to keep track of this reasoning. This steps might be replaced: 👾node-slack-sdk/.github/maintainers_guide.md
Line 91 in d271c4c
With the following commands:
packages/cli-test/package.jsonwith the+cli.X.Y.Zsuffixgit tag @slack/cli-test@2.2.0+cli.2.32.2git push origin "@slack/cli-test@2.2.0+cli.2.32.2"npm publish --workspace packages/cli-test --otp <2FAcode>🌲 Separating updates to release PRs from publishing
The step that creates and updates the release PR is separated from the step performing the publishing. This is done to better enforce permissions on when that job runs.
Notes
Requirements