Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jan 30, 2026

Summary

This PR follows #2483 with a handful of fixes to remove known errors in CI 🤖

🎁 Fixes to package metadata

A change to package metadata for the "publish" step was made using the following command:

npm pkg fix

📺 Removing automatic publishing for @slack/cli-test

The @slack/cli-test package is also ignored from the release workflow for now and adjacent issue are noted to keep track of this reasoning. This steps might be replaced: 👾

3. **Merge and approve**: Merge the release PR, then approve the publish workflow to release packages to npm.

With the following commands:

  1. Bump version in packages/cli-test/package.json with the +cli.X.Y.Z suffix
  2. Create PR with the version bump: chore(cli-test): release @slack/cli-test@2.2.0+cli.2.32.2 #2354
  3. Merge PR to main
  4. Create tag: git tag @slack/cli-test@2.2.0+cli.2.32.2
  5. Push tag: git push origin "@slack/cli-test@2.2.0+cli.2.32.2"
  6. Publish: npm publish --workspace packages/cli-test --otp <2FAcode>

🌲 Separating updates to release PRs from publishing

The step that creates and updates the release PR is separated from the step performing the publishing. This is done to better enforce permissions on when that job runs.

Notes

  • If these changes merge, let's revisit the publishing workflow permissions in project settings 🔏

Requirements

@zimeg zimeg self-assigned this Jan 30, 2026
@zimeg zimeg added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Jan 30, 2026
@zimeg zimeg requested a review from a team as a code owner January 30, 2026 01:02
@zimeg zimeg added release github_actions Pull requests that update GitHub Actions code labels Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.09%. Comparing base (e46cdd8) to head (f12b911).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2492   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files          40       40           
  Lines       11239    11239           
  Branches      713      713           
=======================================
  Hits        10463    10463           
  Misses        764      764           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 94.79% <ø> (ø)
oauth 77.39% <ø> (ø)
socket-mode 61.87% <ø> (ø)
web-api 98.11% <ø> (ø)
webhook 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: f12b911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🚀

@zimeg
Copy link
Member Author

zimeg commented Jan 30, 2026

@WilliamBergamin I think so too 🐌 ✨

Let's merge this after tests run to see soon if a release of @slack/cli-hooks might work as expected with the changes of #2474!

@zimeg zimeg merged commit d84f894 into main Jan 30, 2026
109 of 111 checks passed
@zimeg zimeg deleted the zimeg-build-publish-fixed-packages branch January 30, 2026 20:40
@zimeg
Copy link
Member Author

zimeg commented Jan 30, 2026

👁️‍🗨️ note: The publish workflow now requires approval from a maintainer before running steps:

publish

🪬 issue: But the "ignore" field didn't seem to stop an attempt of publishing "@slack/cli-test" which causes error...

"ignore": ["@slack/cli-test"]

🦋  info @slack/cli-test is being published because our local version (2.2.0+cli.2.32.2) has not been published on npm
🦋  info Publishing "@slack/cli-test" at "2.2.0+cli.2.32.2"
🦋  error an error occurred while publishing @slack/cli-test: undefined You cannot publish over the previously published versions: 2.2.0. 
🦋  error 
🦋  error > @slack/cli-test@2.2.0+cli.2.32.2 prepack
🦋  error > npm run build
🦋  error 
🦋  error 
🦋  error > @slack/cli-test@2.2.0+cli.2.32.2 build
🦋  error > npm run build:clean && tsc
🦋  error 
🦋  error 
🦋  error > @slack/cli-test@2.2.0+cli.2.32.2 build:clean
🦋  error > shx rm -rf ./dist ./coverage
🦋  error 
🦋  error npm warn publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
🦋  error npm warn publish errors corrected:
🦋  error npm warn publish "version" was cleaned and set to "2.2.0"
🦋  error npm notice Security Notice: Classic tokens have been revoked. Granular tokens are now limited to 90 days and require 2FA by default. Update your CI/CD workflows to avoid disruption. Learn more https://gh.io/all-npm-classic-tokens-revoked
🦋  error npm error You cannot publish over the previously published versions: 2.2.0.
🦋  error npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2026-01-30T20_45_36_476Z-debug-0.log
🦋  error 
🦋  error packages failed to publish:
🦋  @slack/cli-test@2.2.0+cli.2.32.2

🔗 https://github.com/slackapi/node-slack-sdk/actions/runs/21529950836/job/62043381449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented github_actions Pull requests that update GitHub Actions code release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants