-
Notifications
You must be signed in to change notification settings - Fork 678
docs: workspaces changes URLs to be full paths #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2494 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 40 40
Lines 11239 11239
Branches 713 713
=======================================
Hits 10463 10463
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukegalbraithrussell Just want to double-check that you want this PR merged into main instead of feat-ai-apps-thinking-steps?
@mwbrooks Yeah I think that makes sense - nothing actually changes except for how the URLs look so it's not dependent on anything. Unless you want 919 docs file changes in that feat branch PR lol Oh and yes I ran the codegen off main, not the thinking steps branch. no accidental early release here! |
Thanks @lukegalbraithrussell! Sounds good to me. Once approved, I'll let you hit merge in case you need to time the merge into |
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks good to me! I wasn't able to review every file, but I ran it through some checks and I don't see anything outside of the URL path changes.
|
@lukegalbraithrussell Huge thanks for these updates! Follows #2478 🏁 |
Summary
This PR only changes the URL appearance in md doc pages
Running codegen changes all the paths. Doing this in a separate PR to not muddy the thinking steps work. Makes the pages a bit more verbose visually but I think it's a net win for clarity for users using search and not being fully aware of which package's pages they end up on
Requirements (place an
xin each[ ])