-
Notifications
You must be signed in to change notification settings - Fork 1
fix: simplify scripts following bolt-python and python-sdk patterns #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⭐ praise: Farewell |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,14 @@ | ||
| #!/bin/bash | ||
| source ./scripts/_utils.sh | ||
| script_dir=$(dirname $0) | ||
| cd ${script_dir}/.. | ||
|
|
||
| set_prj_as_cwd | ||
| # Clean previous builds | ||
| rm -rf dist/ build/ slack_cli_hooks.egg-info/ | ||
|
|
||
| clean_project | ||
| # Install build dependencies unless --no-install is specified | ||
| if [[ "$1" != "--no-install" ]]; then | ||
| pip install -r requirements/build.txt | ||
| fi | ||
|
|
||
| build | ||
| # Build package | ||
| python -m build && twine check dist/* |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| #!/bin/bash | ||
| source ./scripts/_utils.sh | ||
| script_dir=$(dirname $0) | ||
| cd ${script_dir}/.. | ||
|
|
||
| set_prj_as_cwd | ||
|
|
||
| clean_project | ||
|
|
||
| build | ||
| ./scripts/build_pypi_package.sh | ||
|
|
||
| # Upload to test PyPI | ||
| twine upload --repository testpypi dist/* |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| #!/bin/bash | ||
| source ./scripts/_utils.sh | ||
| script_dir=$(dirname $0) | ||
| cd ${script_dir}/.. | ||
|
|
||
| set_prj_as_cwd | ||
| # Install dependencies unless --no-install is specified | ||
| if [[ "$1" != "--no-install" ]]; then | ||
| pip install -U pip | ||
| pip install -r requirements/dev-tools.txt | ||
| fi | ||
|
|
||
| pip install -U pip | ||
| pip install -r requirements/format.txt | ||
|
|
||
| format | ||
| black slack_cli_hooks/ tests/ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🐶 question(non-blocking): We're still leaning toward
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yess definitely still leaning towards ruff 💯 |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| #!/bin/bash | ||
| source ./scripts/_utils.sh | ||
| script_dir=$(dirname $0) | ||
| cd ${script_dir}/.. | ||
|
|
||
| set_prj_as_cwd | ||
|
|
||
| install_development_requirements | ||
| pip install -U pip | ||
| pip install -e . | ||
| pip install -r requirements/testing.txt | ||
| pip install -r requirements/dev-tools.txt |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,11 @@ | ||
| #!/bin/bash | ||
|
|
||
| source ./scripts/_utils.sh | ||
|
|
||
| set_prj_as_cwd | ||
|
|
||
| pip install -U pip | ||
| pip install -r requirements/format.txt | ||
| script_dir=$(dirname $0) | ||
| cd ${script_dir}/.. | ||
|
|
||
| # Install dependencies unless --no-install is specified | ||
| if [[ "$1" != "--no-install" ]]; then | ||
| pip install -U pip | ||
| pip install -r requirements/dev-tools.txt | ||
| fi | ||
|
|
||
| flake8 slack_cli_hooks/ && flake8 tests/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| #!/bin/bash | ||
| script_dir=$(dirname $0) | ||
| cd ${script_dir}/.. | ||
|
|
||
| source ./scripts/_utils.sh | ||
|
|
||
| set_prj_as_cwd | ||
|
|
||
| install_development_requirements | ||
| # Install dependencies unless --no-install is specified | ||
| if [[ "$1" != "--no-install" ]]; then | ||
| ./scripts/install.sh | ||
| fi | ||
|
|
||
| mypy --config-file pyproject.toml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,9 @@ | ||
| #!/bin/bash | ||
|
|
||
| pip uninstall -y slack-cli-hooks && \ | ||
| pip freeze | grep -v "^-e" | xargs pip uninstall -y | ||
| pip uninstall -y slack-cli-hooks | ||
|
|
||
| PACKAGES=$(pip freeze | grep -v "^-e" | sed 's/@.*//' | sed 's/\=\=.*//') | ||
|
|
||
| for package in $PACKAGES; do | ||
| pip uninstall -y $package | ||
| done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 note: Hoping we can soon find shared permissions as projects gain momentum!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yess I've been looking into the agents.md open standard but claude does not support it out of the box 😞
We would need to add it as a skill or rule
I also found that telling LLMs to use the maintainers guide to run unit tests seems to work most of the time, so maybe we can make that our standard