Skip to content

Conversation

@mwbrooks
Copy link
Member

Summary

This pull request standardizes the naming convention in table-driven tests that use the slice pattern across the codebase.

  • Renames the loop variable from tt to tc (test case) in all table-driven tests using the slice pattern

Motivation

This is the first step in refactoring all of our Table Tests to use a consistent style. Right now, we have a mix of Slice and Map Patterns. This step attempts to use consistent naming patterns before we switch all Slice Pattern tests to be Map Pattern.

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Jan 29, 2026
@mwbrooks mwbrooks self-assigned this Jan 29, 2026
@mwbrooks mwbrooks requested a review from a team as a code owner January 29, 2026 17:36
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Jan 29, 2026
Copy link
Member Author

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Tests are currently failing while an issue is resolved in our E2E QA/Dev environment (unrelated to this PR).

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.91%. Comparing base (2853d95) to head (828cd92).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   64.97%   64.91%   -0.07%     
==========================================
  Files         212      212              
  Lines       17623    17623              
==========================================
- Hits        11451    11440      -11     
- Misses       5099     5105       +6     
- Partials     1073     1078       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks What meticulous change!

IMHO these focused changes are bringing huge improvements to overall code health. Thanks so much for driving this 💌 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants