-
Notifications
You must be signed in to change notification settings - Fork 27
refactor(tests): use consistent naming in table tests with the slice pattern #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 Tests are currently failing while an issue is resolved in our E2E QA/Dev environment (unrelated to this PR).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 64.97% 64.91% -0.07%
==========================================
Files 212 212
Lines 17623 17623
==========================================
- Hits 11451 11440 -11
- Misses 5099 5105 +6
- Partials 1073 1078 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwbrooks What meticulous change!
IMHO these focused changes are bringing huge improvements to overall code health. Thanks so much for driving this 💌 ✨
Summary
This pull request standardizes the naming convention in table-driven tests that use the slice pattern across the codebase.
tttotc(test case) in all table-driven tests using the slice patternMotivation
This is the first step in refactoring all of our Table Tests to use a consistent style. Right now, we have a mix of Slice and Map Patterns. This step attempts to use consistent naming patterns before we switch all Slice Pattern tests to be Map Pattern.
Requirements