fix: cleanup after checks for saved apps when opening "app settings" outside of a project #317
Conversation
zimeg
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 64.61% 64.63% +0.01%
==========================================
Files 212 212
Lines 17750 17751 +1
==========================================
+ Hits 11470 11473 +3
+ Misses 5206 5204 -2
Partials 1074 1074 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
📩 Leaving a thought related to changes for reviewers!
| // If no apps exist, open the list of all apps known to the developer | ||
| if slackerror.Is(err, slackerror.ErrInstallationRequired) { | ||
| // Clean up any empty .slack directory and files created during app selection | ||
| clients.AppClient().CleanUp() |
There was a problem hiding this comment.
📝 note: Another approach might check first if this command was run outside of a project before prompting. I'm open to either change, but wanted to be more concise to start.
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Great find! Eventually, we will want to revisit how we create the .slack/ directory. A lot has changed in our approach (e.g. init) since the first implementation that auto-creates .slack/.
|
@mwbrooks I appreciate the review so much and testing too - so glad we're catching this before release 🚢 💨 The ideas around |
Summary
This PR follows #314 to remove the temporary ".slack" directory made when the
app settingscommand is run outside of a project directory.Reviewers
The example below shows expected behavior after this change:
Requirements