Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Jan 30, 2026

Changelog

We now print a debug log if the manifest file was changed but not reinstalled because the manifest.source was set to "remote".

Summary

This PR follows #310 to fix a longstanding confusion the manifest file was changed but not reinstalled because the manifest source of truth is set to app settings 🪬 ✨

Reviewers

Please check outputs with the following comamnds:

$ slack create asdf -t slack-samples/bolt-js-starter-template
$ cd asdf
$ slack run -v
$ vim manifest.json  # Make a change and watch the debug logs

Requirements

@zimeg zimeg self-assigned this Jan 30, 2026
@zimeg zimeg requested a review from a team as a code owner January 30, 2026 23:48
@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment labels Jan 30, 2026
@zimeg zimeg added this to the Next Release milestone Jan 30, 2026
@zimeg zimeg added the changelog Use on updates to be included in the release notes label Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.62%. Comparing base (4ff1172) to head (c841561).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/platform/localserver.go 0.00% 15 Missing ⚠️
cmd/platform/run.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   64.64%   64.62%   -0.03%     
==========================================
  Files         212      212              
  Lines       17751    17755       +4     
==========================================
- Hits        11476    11475       -1     
- Misses       5200     5205       +5     
  Partials     1075     1075              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This works well for me!

📝 I left a minor suggestion to make our skipped message consistent with our other message formats.

Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>
@zimeg zimeg enabled auto-merge (squash) January 31, 2026 00:09
@zimeg
Copy link
Member Author

zimeg commented Jan 31, 2026

@mwbrooks Thanks so much for a fast review for more confidence in development - let's get this merged 🚢 💨

@zimeg zimeg merged commit 252bf7f into main Jan 31, 2026
8 checks passed
@zimeg zimeg deleted the zimeg-fix-run-debug-no-reinstall-watch branch January 31, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants