-
Notifications
You must be signed in to change notification settings - Fork 25
Add corekeys package with CSA/OCRKeyBundle types #1793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces the corekeys package to generate and handle CSA (Connection Signing Authority) and OCR (Off-Chain Reporting) key bundles compatible with the core node.
Changes:
- Adds
csa.gowithGenerateEncryptedCSAKeyandFromEncryptedCSAKeyfunctions for CSA key management - Adds
ocrkeybundle.gowithGenerateEncryptedOCRKeyBundleandFromEncryptedOCRKeyBundlefunctions for OCR key bundle management - Includes comprehensive test coverage for both CSA and OCR key bundle round-trip operations, password validation, and invalid format handling
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| keystore/corekeys/csa.go | Core implementation of CSA key generation, encryption, and decryption utilities |
| keystore/corekeys/csa_test.go | Test coverage for CSA key operations including round-trip, wrong password, and invalid format scenarios |
| keystore/corekeys/ocrkeybundle.go | Core implementation of OCR key bundle generation with support for offchain signing/encryption and onchain signing keys |
| keystore/corekeys/ocrkeybundle_test.go | Test coverage for OCR key bundle operations including round-trip, password validation, invalid format, and invalid key type scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ API Diff Results - No breaking changes |
55b8120 to
af03ae6
Compare
af03ae6 to
2ad9c86
Compare
0fa6d02 to
4d28de5
Compare
4d28de5 to
1488eae
Compare
Requires
Supports