framework/components/blockchain/canton: set labels #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set container labels to framework.DefaultTCLabels() so that tooling that uses this label can find the containers.
friedemannf
approved these changes
Jan 22, 2026
Tofel
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set container labels to framework.DefaultTCLabels() so that tooling that
uses this label can find the containers.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The addition of the
Labels: framework.DefaultTCLabels(),line across multiple container request functions (ContainerRequestfor Canton, Nginx, Postgres, and Splice components) standardizes the labeling of containers. This change makes it easier to manage and identify containers, facilitating better orchestration and monitoring across the testing framework.What
framework/components/blockchain/canton/canton.goLabels: framework.DefaultTCLabels(),tocantonReq. This enables standardized container labeling for Canton components.framework/components/blockchain/canton/nginx.goLabels: framework.DefaultTCLabels(),tonginxReq. This enables standardized container labeling for Nginx components.framework/components/blockchain/canton/postgres.goLabels: framework.DefaultTCLabels(),topostgresReq. This enables standardized container labeling for Postgres components.framework/components/blockchain/canton/splice.goLabels: framework.DefaultTCLabels(),tospliceReq. This enables standardized container labeling for Splice components.