Skip to content

[DX-2742] do not restart CL nodes on cap binary swap#21023

Merged
Tofel merged 1 commit intodevelopfrom
dx-2742-no-node-restart-on-cap-swap
Feb 9, 2026
Merged

[DX-2742] do not restart CL nodes on cap binary swap#21023
Tofel merged 1 commit intodevelopfrom
dx-2742-no-node-restart-on-cap-swap

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Feb 4, 2026

No description provided.

@Tofel Tofel force-pushed the dx-2742-no-node-restart-on-cap-swap branch from f83cd27 to f7cdf20 Compare February 4, 2026 14:07
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Tofel Tofel marked this pull request as ready for review February 4, 2026 15:20
@Tofel Tofel requested review from a team as code owners February 4, 2026 15:20
Copilot AI review requested due to automatic review settings February 4, 2026 15:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the node restart logic from the capability binary swap process. Previously, Docker containers were restarted after swapping capability binaries, but this is no longer necessary as the underlying issues have been resolved.

Changes:

  • Removed Docker container restart logic for nodes affected by capability swaps
  • Removed the waitForURL helper function that was used to verify nodes came back online after restart
  • Cleaned up unused imports (net/http and net/url)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@trunk-io
Copy link

trunk-io bot commented Feb 4, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@skudasov skudasov self-requested a review February 9, 2026 10:07
@Tofel Tofel added this pull request to the merge queue Feb 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2026
@Tofel Tofel added this pull request to the merge queue Feb 9, 2026
Merged via the queue into develop with commit 0c52796 Feb 9, 2026
222 checks passed
@Tofel Tofel deleted the dx-2742-no-node-restart-on-cap-swap branch February 9, 2026 10:57
@teresawong567-afk
Copy link

Crypto can be rewarding if approached the right way. Learning from trusted sources and using verified platforms is key. With the guidance of Adelynn Richardsonftx on Fa--c--ebo--ok or W--h--at--sAp--p at +1 (820) 201-7380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants