Skip to content

Comments

[CRE-491] Extract EVM relay specific config for functions.#21025

Merged
pavel-raykov merged 1 commit intodevelopfrom
move-func2
Feb 4, 2026
Merged

[CRE-491] Extract EVM relay specific config for functions.#21025
pavel-raykov merged 1 commit intodevelopfrom
move-func2

Conversation

@pavel-raykov
Copy link
Collaborator

@pavel-raykov pavel-raykov commented Feb 4, 2026

This extraction is needed to be able to move relay/evm/functions to the chainlink-evm repository.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production
Copy link

@pavel-raykov pavel-raykov marked this pull request as ready for review February 4, 2026 18:41
@pavel-raykov pavel-raykov requested review from a team as code owners February 4, 2026 18:41
Copilot AI review requested due to automatic review settings February 4, 2026 18:41
@pavel-raykov
Copy link
Collaborator Author

.cora

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extracts EVM relay-specific configuration for functions into a dedicated config package, refactoring the PluginConfig structure to separate relay concerns from plugin-specific concerns.

Changes:

  • Created a new RelayConfig struct in core/services/relay/evm/functions/config/config.go to hold EVM relay-specific configuration fields
  • Updated PluginConfig to embed RelayConfig instead of duplicating these fields
  • Renamed references from pluginConfig to relayConfig or relayFunctionsConfig where appropriate throughout the codebase

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
core/services/relay/evm/functions/config/config.go New file defining RelayConfig struct with EVM relay-specific fields
core/services/relay/evm/functions/logpoller_wrapper.go Updated to use RelayConfig instead of PluginConfig and renamed variable references
core/services/relay/evm/functions/logpoller_wrapper_test.go Updated imports and test setup to use new config structure
core/services/relay/evm/functions.go Updated to use new config package and renamed variables for clarity
core/services/ocr2/plugins/functions/config/config.go Refactored to embed RelayConfig instead of duplicating fields
core/services/relay/evm/functions/config_poller.go Removed extraneous blank line

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pavel-raykov pavel-raykov requested review from jmank88 and removed request for bolekk February 4, 2026 18:41
@jmank88 jmank88 requested a review from bolekk February 4, 2026 19:01
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 4, 2026
Merged via the queue into develop with commit 07c9b82 Feb 4, 2026
276 of 278 checks passed
@pavel-raykov pavel-raykov deleted the move-func2 branch February 4, 2026 19:31
@trunk-io
Copy link

trunk-io bot commented Feb 4, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants