Improve the BuildMe example #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cmoulliard
commented
Apr 23, 2025
cmoulliard
commented
- Improve the BuildMe example
- Verify if the mandatory env vars are well declared
- Add a new env var to support to enable/disable: USE_DAEMON
- Bump the version to use now: 0.0.14
BarDweller
requested changes
Apr 23, 2025
Collaborator
BarDweller
left a comment
BarDweller
left a comment
There was a problem hiding this comment.
Looks good, just minor comments.. =)
Member
Author
|
I fixed the points you mentioned. Can you review it again please @BarDweller ? |
Signed-off-by: cmoulliard <cmoulliard@redhat.com>
cmoulliard
force-pushed
the
improve-buildme
branch
from
5c014ce to
c3f8cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.