podman windows and host/socket updates #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported via : quarkusio/quarkus#47940
The cause was trying to use replaceAll to swap \ for /, and forgetting that replaceAll uses regex, so requires \\ not just \
However, it should have been possible to work around the issue by specifying host/socket as arguments, and that failed, because the sequence of invocations creating the config still drove the autodetect logic.
This moves the host/socket to a sub config object, ensuring they are set into the docker config object as a single operation.
This a breaking change to the config api, as withDockerHost & withDockerSocket are removed, and callers should use withHostAndSocketConfig instead
Also contains minor tweaks to ensure if both overrides are present, the autodetect logic is skipped entirely.