NO-SNOW: Add core library import #2657
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
53
to
60
| # Load the core library - failures are captured in core_loader and don't prevent module loading | ||
| try: | ||
| core_loader.load() | ||
| except Exception: | ||
| # Silently continue if core loading fails - the error is already captured in core_loader | ||
| # This ensures the connector module loads even if the minicore library is unavailable | ||
| pass | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is probably redundant because load method is already big try / except
sfc-gh-pczajka
approved these changes
Dec 4, 2025
Collaborator
sfc-gh-pczajka
left a comment
sfc-gh-pczajka
left a comment
There was a problem hiding this comment.
Approved with small non-blocking comments
| if self._is_core_disabled(): | ||
| self._error = "mini-core-disabled" | ||
| return | ||
| self._error = "still-loading" |
Collaborator
There was a problem hiding this comment.
Could we wrap it into an error / change class definition to Exception | str | None?
| def load(self): | ||
| """Spawn a separate thread to load the minicore library (non-blocking).""" | ||
| if self._is_core_disabled(): | ||
| self._error = "mini-core-disabled" |
Collaborator
There was a problem hiding this comment.
Could we wrap it into an error / change class definition to Exception | str | None?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: