[SofaCore] Restore xml and python different naming conventions#2773
[SofaCore] Restore xml and python different naming conventions#2773fredroy merged 1 commit intosofa-framework:masterfrom
Conversation
|
[ci-depends-on] detected during build #1. To unlock the merge button, you must
|
|
[ci-build][with-all-tests] |
|
[ci-depends-on] detected during build #2. To unlock the merge button, you must
|
|
Hi, Me again... Sorry I didn't notice but the old behavior has not been really restored. Before, the default name was |
|
To me this change is a perfect use case for the Lifcycle feature management introduced in: With such it would be trivial when loading a scene to write something like that: from Sofa.Lifecycle import __feature__
def myOldNamingScene(root):
"""A scene or prefab that use the old naming scheme"""
pass
def myNewNamingScene(root):
"""A scene or prefab that use the new naming scheme"""
pass
def createScene(root):
with __feature__("uniform-naming-scheme",True):
myNewNamingScene(root)
myOldNamingScene(root) |
Sorry, I thought it was the opposite due to https://peps.python.org/pep-0008/#function-and-variable-names. So, let's merge #2801 |
Based on the discussion started in #2631 and finished during a dev meeting, this PR restores the old behavior:
Nevertheless, the class that provides the names is still common.
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/241]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if