[Spring] Add fixed weak constraint and examples#4750
Open
bakpaul wants to merge 31 commits intosofa-framework:masterfrom
Open
[Spring] Add fixed weak constraint and examples#4750bakpaul wants to merge 31 commits intosofa-framework:masterfrom
bakpaul wants to merge 31 commits intosofa-framework:masterfrom
Conversation
bakpaul
added
pr: status to review
Contributor
|
A duplicate of code ? |
fredroy
reviewed
May 22, 2024
Contributor
fredroy
left a comment
fredroy
left a comment
There was a problem hiding this comment.
Identical description with RestShapeFF ? 👮
...onent/SolidMechanics/Spring/src/sofa/component/solidmechanics/spring/FixedWeakConstraint.cpp
Outdated
Show resolved
Hide resolved
bakpaul
added
pr: status wip
… to add inline method to regroup addForce implementations and apply it to RestShapeSpringsFF
… apply it to RestShape
…cialize it inside the RestShapeSpringForcefield
This was referenced Dec 10, 2024
…straint part which doesn't make any sense now
Contributor
Author
|
[ci-build][with-all-tests] |
Collaborator
|
[ci-depends-on] detected during build #36. To unlock the merge button, you must
|
Collaborator
|
[ci-depends-on] detected during build #37. To unlock the merge button, you must
|
Contributor
|
ci-depends-on ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
FixedWeakConstraint. It is really a simplified version ofRestShapeSpringForcefieldthat only fixes points with respect to their rest_shape given one single value of stiffness. I didn't use an inheritance becauseRestShapeSpringForcefielddoes too much and the two set of features aren't really compatible. Keep it simple...This completes the holy trinity of fixed constraints, now we will have Weak, Projective and Langrangian fixed constraints. It unifies the mechanism.
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/492]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/312]
[ci-depends-on https://github.com/SofaDefrost/STLIB/pull/127]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/160]
[ci-depends-on https://github.com/SofaDefrost/Cosserat/pull/148]
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/146]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.Inverse/pull/47]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.DesignOptimization/pull/3]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if