[Lagrangian] Add corrected Jacobi constraint solving method#5680
Merged
hugtalbot merged 20 commits intosofa-framework:masterfrom Nov 11, 2025
Merged
Conversation
…info in GenericCosntraintSolver data that are dependent on the method type. Need to find a way of setting the solving method by adding a component in the scene.
…ritance. Now the constraintProblem is only a container
…oposed in the original paper
bakpaul
added
pr: status to review
hugtalbot
changed the title
hugtalbot
added
pr: new feature
alxbilger
reviewed
Sep 23, 2025
...an/Solver/src/sofa/component/constraint/lagrangian/solver/ImprovedJacobiConstraintSolver.cpp
Outdated
Show resolved
Hide resolved
...an/Solver/src/sofa/component/constraint/lagrangian/solver/ImprovedJacobiConstraintSolver.cpp
Outdated
Show resolved
Hide resolved
...an/Solver/src/sofa/component/constraint/lagrangian/solver/ImprovedJacobiConstraintSolver.cpp
Outdated
Show resolved
Hide resolved
bakpaul
force-pushed
the
25_08_add_corrected_jacobi_constraint_solving_method
branch
from
ebffdd6 to
3e8b76a
Compare
Contributor
|
[ci-build][with-all-tests] |
alxbilger
reviewed
Oct 23, 2025
...an/Solver/src/sofa/component/constraint/lagrangian/solver/ImprovedJacobiConstraintSolver.cpp
Outdated
Show resolved
Hide resolved
...an/Solver/src/sofa/component/constraint/lagrangian/solver/ImprovedJacobiConstraintSolver.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
hugtalbot
approved these changes
Nov 6, 2025
hugtalbot
removed
the
pr: status to review
hugtalbot
added
the
pr: status ready
Contributor
|
[ci-build][with-all-tests][force-full-build] |
1 similar comment
Contributor
Author
|
[ci-build][with-all-tests][force-full-build] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to add a new simple constraint solving method as a ConstraintSovler using introduced refactoring in #5666
It is basically a Jacobi with a bit of conjugate residue.
I plan to make is multithreaded to be able to run the added example at more than 3Hz...
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if